Using preferredemail as a public email id is wrong and broken.
Bug #643345 reported by
Jeroen T. Vermeulen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Jeroen T. Vermeulen |
Bug Description
Several branch exports are failing, including "datum" trunk series, with
AttributeError(
Related branches
lp:~jtv/launchpad/bug-643345
- Tim Penhey (community): Approve (production-change)
- Robert Collins: Pending (production-change) requested
- Launchpad code reviewers: Pending (code) requested
-
Diff: 262 lines (+108/-24)4 files modifiedlib/lp/code/model/directbranchcommit.py (+21/-4)
lib/lp/code/tests/test_directbranchcommit.py (+71/-12)
lib/lp/translations/scripts/tests/test_translations_to_branch.py (+13/-5)
lib/lp/translations/scripts/translations_to_branch.py (+3/-3)
Changed in rosetta: | |
status: | New → In Progress |
importance: | Undecided → Critical |
assignee: | nobody → Jeroen T. Vermeulen (jtv) |
milestone: | none → 10.10 |
summary: |
- Failing branch exports + Using preferredemail as a public email id is wrong and broken. |
Changed in launchpad-code: | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in launchpad: | |
status: | Triaged → Fix Released |
To post a comment you must log in.
The problem seems to be that DirectBranchCommit produces a bzr user id from format_ address_ for_person( branch. owner), but format_ address_ for_person won't work if the person in question has no preferred email.
In the case of Datum, and probably a lot of the other failing branches, the owner is a team and has no contact address. We'll have to search much harder for a valid email address.