Launchpad itself

  1. Bug #614275
  2. Comment #0

Comment 0 for bug 614275

Revision history for this message
Julian Edwards (julian-edwards) wrote : RotatableLogFileObserver is tested in the wrong place

RotatableFileLogeObserver is currently only tested in the buildd-manager tests in lib/lp/buildmaster. This is wrong for 2 reasons:

1. it relies on the behaviour of the buildd-manager
2. it's slow, because it waits several seconds for a logging event in the buildd-manager code

The tests should live in the lp.services.twistedsupport test code and use Deferreds or task.Clock() to avoid a long wait in the test. I have also disabled the tests in the buildd-manager test file because it's preventing me from landing a change that reduces the logging.