On Sunday 01 August 2010 21:11:24 you wrote:
> Public bug reported:
>
> Hi,
>
> getPackagesetsForUploader uses Store.find, which doesn't return an
> SQLObject result set.
>
> This breaks assumptions, such as __nonzero__ being implemented, which
> caused a (small) bug in checkUpload().
There's probably many many places like this throughout the LP code base where
we're mixing SQLObject and Storm. :/
A good start would be to implement __nonzero__ for ResultSet. And then
converting our SQLObject classes to Storm can be done over time.
On Sunday 01 August 2010 21:11:24 you wrote: orUploader uses Store.find, which doesn't return an
> Public bug reported:
>
> Hi,
>
> getPackagesetsF
> SQLObject result set.
>
> This breaks assumptions, such as __nonzero__ being implemented, which
> caused a (small) bug in checkUpload().
There's probably many many places like this throughout the LP code base where
we're mixing SQLObject and Storm. :/
A good start would be to implement __nonzero__ for ResultSet. And then
converting our SQLObject classes to Storm can be done over time.
BTW James what was the bug in checkUpload() ?