Launchpad itself

Confusions between import and mirror branches

Bug #611837 reported by Barry Warsaw
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jelmer Vernooij

Bug Description

I wanted to make https://code.edge.launchpad.net/~python-dev/python/2.7 available as a Bazaar branch on Launchpad, so I went to launchpad.net/python and clicked on "Register a branch". This gave me three options, one of which was "mirror". Well, I did want to mirror the upstream Subversion branch, but that's not actually what "mirror" means to Launchpad. I really wanted a branch import from a foreign VCS.

So, two suggestions:

* Add import to register a branch page
* Explain the difference between import and mirror

Related branches

lp:~jelmer/launchpad/bzr-code-imports-ui
Benji York (community): Approve (code)
Michael Hudson-Doyle: Pending (code) requested
Brad Crittenden: Pending requested
Ian Booth: Pending (code*) requested
Diff: 1310 lines (+227/-479)
17 files modified
lib/lp/app/widgets/doc/launchpad-radio-widget.txt (+3/-3)
lib/lp/code/browser/branch.py (+8/-50)
lib/lp/code/browser/codeimport.py (+30/-10)
lib/lp/code/browser/tests/test_branch.py (+3/-13)
lib/lp/code/enums.py (+2/-2)
lib/lp/code/stories/branches/xx-branch-deletion.txt (+0/-2)
lib/lp/code/stories/branches/xx-branch-url-validation.txt (+0/-72)
lib/lp/code/stories/branches/xx-creating-branches.txt (+0/-188)
lib/lp/code/stories/branches/xx-junk-branches.txt (+2/-4)
lib/lp/code/stories/codeimport/xx-create-codeimport.txt (+62/-16)
lib/lp/code/templates/branch-form-macros.pt (+0/-42)
lib/lp/code/templates/branch-import-details.pt (+28/-4)
lib/lp/code/templates/codeimport-list.pt (+1/-0)
lib/lp/code/templates/codeimport-new.pt (+16/-0)
lib/lp/registry/browser/productseries.py (+35/-51)
lib/lp/registry/browser/tests/productseries-setbranch-view.txt (+36/-21)
lib/lp/registry/templates/productseries-codesummary.pt (+1/-1)
Brad Crittenden (community): Approve
Michael Hudson-Doyle: Pending (code) requested
Diff: 720 lines (+88/-339)
11 files modified
lib/lp/code/browser/branch.py (+4/-47)
lib/lp/code/browser/codeimport.py (+23/-5)
lib/lp/code/browser/tests/test_branch.py (+3/-13)
lib/lp/code/enums.py (+2/-2)
lib/lp/code/stories/branches/xx-creating-branches.txt (+0/-179)
lib/lp/code/stories/codeimport/xx-create-codeimport.txt (+1/-0)
lib/lp/code/templates/branch-form-macros.pt (+0/-42)
lib/lp/code/templates/branch-import-details.pt (+6/-0)
lib/lp/code/templates/codeimport-new.pt (+14/-0)
lib/lp/registry/browser/productseries.py (+34/-50)
lib/lp/registry/templates/productseries-codesummary.pt (+1/-1)
Revision history for this message
Curtis Hovey (sinzui) wrote :

I wonder if the layout of +setbranch could be reused. I think import verses mirror is clearer.

affects: launchpad → launchpad-code
Revision history for this message
Tim Penhey (thumper) wrote :

Yes we should look to reuse, and should also fix the bugs in +setbranch too.

tags: added: code-import confusing-ui
Changed in launchpad-code:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I just came across this helping a user in #launchpad.

I think it would make a lot of sense for mirrorred branches and imported branches to be the same thing, at least UI-wise.

Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 611837] Re: Confusions between import and mirror branches

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10-12-10 10:08 AM, Jelmer Vernooij wrote:
> I just came across this helping a user in #launchpad.
>
> I think it would make a lot of sense for mirrorred branches and imported
> branches to be the same thing, at least UI-wise.

Using the import slaves to do mirroring would be a bit like swatting a
fly with a sledgehammer, but we kinda already do it for svn and hg, so
it's probably feasible. It might make sense if we could completely
eliminate the puller as a result.

But some of the differences in UI are inextricably linked to the
differences in the underlying implementation, so I think we can only
make the UI more similar, not the same.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0CU+cACgkQ0F+nu1YWqI2VKgCfWotCI8bE2mrnTQ0kYMGjjxvE
CZ8AnjwjZSaliXX1JyK2VQhnJzfVyyj2
=b/ap
-----END PGP SIGNATURE-----

Jelmer Vernooij (jelmer)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Jelmer Vernooij (jelmer)
Robert Collins (lifeless)
Changed in launchpad:
importance: Medium → High
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14112 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14112>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Jelmer Vernooij (jelmer)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.