Parse errors should give a "USAGE" for the line that they are parsing.
Bug #604718 reported by
James Westby
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Aaron Bentley | ||
| bzr-builder |
Fix Released
|
High
|
Aaron Bentley | ||
Bug Description
bzr: ERROR: Error parsing /tmp/recipe:3:32: End of line while looking for the branch url.
that's all well and good, but if you don't know the format you will be saying "it's already got a branch url!"
What we should do is print a "usage" for the line that we are parsing, and also explain what part we matched where.
bzr: ERROR: Error parsing /tmp/recipe:3:32: End of line while looking for the branch url. merge instructions have the format "merge <name> <url> [<revspec>]". In this case we parsed "lp:whatever" as the <name>.
Related branches
lp:~abentley/bzr-builder/usage
- James Westby: Approve
- Martin Pool (community): Approve
-
Diff: 386 lines (+125/-64)2 files modifiedrecipe.py (+58/-25)
tests/test_recipe.py (+67/-39)
lp:~abentley/launchpad/better-recipe-errors
- Tim Penhey (community): Approve
-
Diff: 61 lines (+25/-7)3 files modifiedlib/lp/code/browser/sourcepackagerecipe.py (+1/-4)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+23/-2)
utilities/sourcedeps.conf (+1/-1)
| Changed in bzr-builder: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: recipe |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in bzr-builder: | |
| assignee: | nobody → Aaron Bentley (abentley) |
| Changed in launchpad-code: | |
| assignee: | nobody → Aaron Bentley (abentley) |
| Changed in bzr-builder: | |
| status: | Triaged → In Progress |
| Changed in bzr-builder: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-code: | |
| milestone: | none → 10.12 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
| Changed in bzr-builder: | |
| milestone: | none → 0.7 |
| Changed in bzr-builder: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11992 <http://