Comment 5 for bug 595957
Revision history for this message
| Aaron Bentley (abentley) wrote Re: [Bug 595957] Re: archive uploader tries to move the changelog to the current working directory | #5 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/21/2010 03:03 AM, Michael Nelson wrote:
> Additionally, afaik prior to SPRecipeBuilds process-upload was only
> called with sourcepackages with a cron invoked with:
> "/srv/launchpad
> lp_queue user.
Ah. It's misleading, then, that the behaviour is defined in a base class.
> I think it's a bug (or just wrong) that the file is being saved to the
> CWD just to be uploaded.
Agreed.
> If there's a quick permission fix to enable the
> SPRecipe builds to be uploaded - great (although I don't think it should
> be granting write access to the lp code root!)
I think that granting write access to the lp code root would be the only
possible permission fix.
We could update the way we invoke the script so that it runs in a temp
directory. That would be a hack, but it would mirror the way it works
on germanium, so I'd expect it to work.
>, but otherwise I think we
> should instead update unpackAndCheckS
> moving it to a separate *tmp* directory, and upload it to the librarian
> from there.
Yes, I think this is the right solution.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkw
hIQAmwbXhas9WIv
=Bsjk
-----END PGP SIGNATURE-----