Comment 4 for bug 595957

Aaron, that was what I thought initially, but I had a losa check germanium's launchpad root for a changelog and:

{{{
17:02 < Chex> noodles: germanium:/srv/launchpad.net/codelines/current$ ls -la changelog : cannot access changelog: No such file or directory
}}}

Whereas on dogfood and my local directory where I was testing the SPRecipeBuilds there is a changelog in the launchpad root for the last SPRecipe build that I'd run).

Additionally, afaik prior to SPRecipeBuilds process-upload was only called with sourcepackages with a cron invoked with: "/srv/launchpad.net/codelines/current/scripts/process-upload.py" as the lp_queue user.

I think it's a bug (or just wrong) that the file is being saved to the CWD just to be uploaded. If there's a quick permission fix to enable the SPRecipe builds to be uploaded - great (although I don't think it should be granting write access to the lp code root!), but otherwise I think we should instead update unpackAndCheckSource() to check the changelog by moving it to a separate *tmp* directory, and upload it to the librarian from there.