Launchpad itself

  1. Bug #549340
  2. Comment #1

Comment 1 for bug 549340

Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: [Bug 549340] [NEW] BuildQueue.destroySelf erroneously assumes that all jobs are Storm objects

On Saturday 27 March 2010 04:42:06 you wrote:
> Public bug reported:
>
> BuildQueue.destroySelf does this:
>
> Store.of(specific_job).remove(specific_job)
>
> That doesn't work for TranslationsTemplateBuildJobs, which are not
> themselves Storm objects (their BranchJob is).
> specific_job.destroySelf() may be better.

Hmm.

We should really be using Storm objects for any new database objects, why is
TranslationsTemplateBuildJob not so?