Displaying bug patch badges in listing is inefficient, causes many timeouts
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Launchpad itself |
Critical
|
Eleanor Berger | ||
Bug Description
The way we query for patches to display as badges on bug listings is very inefficient (one query per bug) and causes many timeouts.
Related branches
- Gary Poster (community): Approve (release-critical) on 2010-01-25
- Aaron Bentley (community): Approve on 2010-01-25
-
Diff: 69 lines (+11/-3)4 files modifiedlib/canonical/launchpad/webapp/tales.py (+4/-0)
lib/lp/bugs/browser/bugtask.py (+3/-1)
lib/lp/bugs/browser/cvereport.py (+2/-1)
lib/lp/registry/browser/milestone.py (+2/-1)
| Eleanor Berger (intellectronica) wrote : | #1 |
| Eleanor Berger (intellectronica) wrote : | #2 |
~jml, who also gets to say "i told you so", having spotted the problem in review, tells me that may be a good example of how this can be optimized is found in lib/lp/
| Björn Tillenius (bjornt) wrote : Re: [Bug 512262] Re: Displaying bug patch badges in listing is inefficient, causes many timeouts | #3 |
On Mon, Jan 25, 2010 at 10:15:25AM -0000, Tom Berger wrote:
> ~jml, who also gets to say "i told you so", having spotted the problem
> in review, tells me that may be a good example of how this can be
> optimized is found in lib/lp/
I would suggest looking in lib/lp/
how it's done for the rest of the badges in the bug listings. Search for
BugListingBatch
patches as well.
| Changed in malone: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Tom Berger (intellectronica) |
| assignee: | Tom Berger (intellectronica) → nobody |
| milestone: | 10.01 → none |
| Changed in malone: | |
| status: | In Progress → New |
| importance: | High → Undecided |
| Changed in malone: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Tom Berger (intellectronica) |
| milestone: | none → 10.01 |
| Eleanor Berger (intellectronica) wrote : | #4 |
Tested the fix on staging and it works well.
| Changed in malone: | |
| importance: | High → Critical |
| Changed in malone: | |
| status: | In Progress → Fix Committed |
| tags: | added: current-rollout-blocker |
| tags: | removed: oops |
| Changed in malone: | |
| status: | Fix Committed → Fix Released |
See OOPS-1486ED402 for example.