Launchpad itself

Bug #506018
Comment #9

Comment 9 for bug 506018

Revision history for this message

Bryce Harrington (bryce) wrote on 2010-01-14: Re: [Bug 506018] Re: Need a "+patches" view: report lists patches attached to bugs.

On Thu, Jan 14, 2010 at 07:16:50PM -0000, Jorge O. Castro wrote:
> In the mockup you mention if it's worth having the person's name
> mentioned in the popup, and Bryce is wondering about the use case with
> multiple patches per bug. What about having a Patch Column at the end,
> and each patch is that little bandaid icon, so if a bug has 3 bandaids
> it has three patches attached to it, and then on hover you get name of
> submitter and description?
>
> I am guessing that an ubuntu maintainer who has a trust relationship
> with another developer wouldn't mind seeing who submitted the patch so
> they can triage it in their mind better. "Oh, this guy always has good
> patches, let me look at that right away." or something.

Wow, I should have read your comment before posting mine. :-)
Yes, complete agreement.

kfogel writes:
> Bryce, attaching a screenshot with proposals for changes (I ended up
> circling back to your basic design, after trying to figure out a way to
> make the view solely patch-centric... that didn't work well, because the
> bugs and bug tasks have important information that the user probably
> needs to see too).

I like this. And I agree with all your notations. I include the
summary as a sortable item only due to the generality of the table
sorting javascript I'm using; sorting by summary has no usefulness.
Hover-over to show patch info is sweet.

Regarding showing the patch submitter as a column, I do think it is
useful info but I'm torn as to whether it's worth devoting a column to
it. On the pro side: A) You could sort by submitter, to make it easy to
find all of a particular person's submissions, B) It'd clue you in that
a patch is just from another package maintainer (maybe yourself) so no
need to review it, C) it'd imply a trust measure as jorge mentions. On
the con side is that it'd add another wide column.

Hmm. Would it be possible to display just an icon for the person? If
so, I think that would give the benefits without sacrificing so much
space. If not, then maybe omit showing the patch submitter for now
(just include in the popup) and see if there's a big demand for it at
roll out and decide then?

Bryce

On Thu, Jan 14, 2010 at 07:16:50PM -0000, Jorge O. Castro wrote:
> In the mockup you mention if it's worth having the person's name
> mentioned in the popup, and Bryce is wondering about the use case with
> multiple patches per bug. What about having a Patch Column at the end,
> and each patch is that little bandaid icon, so if a bug has 3 bandaids
> it has three patches attached to it, and then on hover you get name of
> submitter and description?
> 
> I am guessing that an ubuntu maintainer who has a trust relationship
> with another developer wouldn't mind seeing who submitted the patch so
> they can triage it in their mind better. "Oh, this guy always has good
> patches, let me look at that right away." or something.

Wow, I should have read your comment before posting mine.  :-)
Yes, complete agreement.

I like this.  And I agree with all your notations.  I include the
summary as a sortable item only due to the generality of the table
sorting javascript I'm using; sorting by summary has no usefulness.
Hover-over to show patch info is sweet.

Regarding showing the patch submitter as a column, I do think it is
useful info but I'm torn as to whether it's worth devoting a column to
it.  On the pro side: A) You could sort by submitter, to make it easy to
find all of a particular person's submissions, B) It'd clue you in that
a patch is just from another package maintainer (maybe yourself) so no
need to review it, C) it'd imply a trust measure as jorge mentions.  On
the con side is that it'd add another wide column.

Hmm.  Would it be possible to display just an icon for the person?  If
so, I think that would give the benefits without sacrificing so much
space.  If not, then maybe omit showing the patch submitter for now
(just include in the popup) and see if there's a big demand for it at
roll out and decide then?

Bryce