Comment 14 for bug 498181

Revision history for this message
C de-Avillez (hggdh2) wrote : Re: cannot propose a member to a team trough launchpadlib

Hi Edwin,

Yes, given what you describe above, we are most certainly abusing the API -- but, in our defence, this is not documented :-)

First of all -- this was a hack. When we started the bug-squad mentorship programme (which, BTW, still needs a lot of details worked out), we were asking the cadidates to email the ML asking for it. Eventually we decided this was not working, and moved over to a LP team, where the candidates would propose themselves (very much like you expected). When a candidate is accepted for mentorship, the mentor would them accept this candidate into the team.

But we were left with a number of candidates, waiting for a response to their ML request. So Pedro and I went on with this hack, with the idea of getting these candidates, and proposing them to the team -- where they would wait for a mentor to pick them up. This was done mostly out of respect with them (they *did* follow the procedures in place; if we changed the procedures later on, the then-currently pending candidates should not be penalised).

Since, it seems, we are the first to try it (and Pedro actually *did* succeed when he first tried, then we had a new LP deployment, and both Pedro and I could not do it anymore), then I guess this is not a critical issue. I still see benefits if this is allowed, though.

But.

I just went and looked at some of the currently proposed members, via the UI (on edge). I still cannot see the email address(es) of those that set it as private, and I am one of the team admins.

How is it the email address gets revealed? This is actually a relevant question, since a team admin can always contact a candidate via standard UI (via the ./+contactuser), like anybody else. And, if someone decided to set email to private, this setting should be respected everywhere.

Oooh, I see now where this is done -- on the LP email sent of behalf of the team, the proponent is CC-ed. I humbly suggest this is wrong (either always, or if email is set to private, the proponent should be BCC-ed).