Comment 0 for bug 491330

Revision history for this message
Michael Nelson (michael.nelson) wrote : Update Builder history UI for generalised builders

Currenty our user interface assumes that the build history of a builder consists solely of binary package builds:

https://edge.launchpad.net/builders/rothera/+history

We will need to do something like generalising IBuilder.getBuildRecords() so that it returns the specific build records for all BuildFarmJobs for display at the above URL, but this will not be implementing the (soyuz-specific) IHasBuildRecords requirements for filtering etc. When the viewer filters by a certain job type (say 'binary package builds'), we *could* have IBuilder.getBuildRecords() instead delegate to the specific behavior (which in this case would be BinaryPackageBuildBehavior.getBuildRecords() which would implement IHasBuildRecords).

We'll also have to think about whether we want that page to display different filtering options depending on the job type - that could be confusing, but it depends how important the current filtering on the builder history is (I'm guessing that it is used quite a lot by the admins). The other option would be to have separate traversals for each type - or just specifically the binary package type due to the previous expectations.