the code import system calls requestMirror even if no revisions were imported

Bug #487357 reported by Michael Hudson-Doyle on 2009-11-24
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Medium
Michael Hudson-Doyle

Bug Description

Even when a code import doesn't import any revisions we call requestMirror. This creates more work for the puller -- about half the runs of the puller currently are for import branches, despite import branches being 1% of all branches on lp -- and even a noop puller run is fairly expensive owing to process start up overheads.

Maybe the fix is to make noop puller runs cheaper by using a process pool or something, but this seems a waste in any case.

Related branches

Jonathan Lange (jml) on 2009-11-25
tags: added: code-import
Michael Hudson-Doyle (mwhudson) wrote :

Aaron suggested a lo-fi way of fixing this: have the worker exit with a distinct exit code in each of the "success, new revisions", "success, no new revisions" and "error" cases. The way Python is, we more-or-less have to have exit == 1 for the error case, but we can us anything we like for the other cases.

On Tue, Dec 22, 2009 at 11:57 AM, Michael Hudson
<email address hidden> wrote:
> Aaron suggested a lo-fi way of fixing this: have the worker exit with a
> distinct exit code in each of the "success, new revisions", "success, no
> new revisions" and "error" cases.  The way Python is, we more-or-less
> have to have exit == 1 for the error case, but we can us anything we
> like for the other cases.

I like it.

jml

Tim Penhey (thumper) on 2010-01-26
Changed in launchpad-code:
assignee: nobody → Michael Hudson (mwhudson)
importance: Undecided → Medium
status: New → In Progress
Changed in launchpad-code:
milestone: none → 10.02
Tim Penhey (thumper) on 2010-02-16
Changed in launchpad-code:
status: In Progress → Fix Committed
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers