Comment 2 for bug 481340

Revision history for this message
Karl Fogel (kfogel) wrote : Re: "Request a review" form is confusing

Also:

If you manually just type the reviewer's username into that field (because you already know their name and don't need to do a search), it's not clear what to do next. If you hit Enter, that just causes a search; for example, I entered "adeuring" and hit Enter, and it did a search in which Abel Deuring was the only result. That's unexpected, because usually hitting Enter submits.

If you don't figure out that the way to submit is to hit Enter and then *click* on the person's name as a search result, you'll be confused as to how to submit at all. This can happen especially when you're also going to enter something for the Review Type field.

For example, one one merge proposal, I clicked "Request another review", entered "stub" by hand in the name field, and then proceeded directly to the Review Type field and entered "db" there -- unaware that my "stub" had not really been entered because I hadn't hit Enter and clicked on a search result yet. Unsure of how to submit, now that I had filled in "stub" and "db", I just hit the "(x)" in the upper right corner, thought that felt wrong, since usually that closes the window without submitting... which is exactly what it did!

I had to poke around quite a bit just to figure out how to submit a username *and* a review type :-).

Proposed solution:

Put a "Submit" button on the window, and allow a manually-entered username to be submitted (i.e., no need to do a search if you know the name).