Comment 10 for bug 458200

Revision history for this message
Michael Nelson (michael.nelson) wrote :

I had this ready to land, but there was a legit test failure which needs input (it's really a registry bug, at least, the changes in the above MP were all in browser/person.py etc., Muharem and I just continued on it as it was a good pairing bug).

The fix that I did in the above branch is: "Instead of showing the section when there is at least one public ppa, we show the section when there is at least one ppa that the current user can view.", but clearly, this affects the test below, as a disabled PPA is not viewable (but is public).

From lp/registry/browser/tests/person-views.txt
{{{
If we disable Cprov's PPA, the section is still presented to anyone.

    >>> login("<email address hidden>")
    >>> cprov.archive.enabled = False

    >>> login(ANONYMOUS)
    >>> view = create_initialized_view(cprov, "+index")
    >>> view.should_show_ppa_section
    True
}}}

If Curtis/registry is happy for the above behavior to change, I'll update the branch and land it.