merge proposal status info should reflect status of prerequisite branch

Bug #456418 reported by Aaron Bentley on 2009-10-20
36
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Low
Unassigned

Bug Description

The status info shown about a merge proposal should include information about a prerequisite branch.

It should indicate
 - whether the branch has already been merged
 - whether the branch has been proposed for merging
 - whether the branch has been approved for merging

Aaron Bentley (abentley) on 2009-10-20
summary: - merge proposal status info shoulld reflect status of prerequisite branch
+ merge proposal status info should reflect status of prerequisite branch
Aaron Bentley (abentley) wrote :

This might include the status of any merge proposals involving the prerequisite and the target.

Jamu Kakar (jkakar) wrote :

I was just about to file a bug about this when I found that it's
already been filed. I often end up having to drive around Launchpad
to figure out if the prerequisite listed on a merge proposal is merged
or not. I'd like to see something like:

  Proposed branch: lp:~jkakar/project/proposed-branch
       Merge into: lp:project
Prequisite branch: lp:~jkakar/project/prerequisite-branch (Needs review)

The status for the prerequisite branch's merge proposal should only be
shown if its targetted to merge into the same branch as the proposed
branch. I suppose listing the merge proposal status gets tricky when
a branch has more than one merge proposal, but perhaps you can do
something like '(_Needs review_ and _2 more_)'. The '2 more' link
will take the user to the branch page, which lists all the active
merge proposals. The newest merge proposal would be the one that was
shown, all the others would be the 'X more' ones.

Anyway, the primary thing I want to know when a prerequisite branch is
listed is whether or not I need to pull it to diff the proposed branch
against. In many cases, by the time I get to a merge proposal the
prerequisite branch has already been merged to trunk and I don't need
to do anything special.

Also, perhaps the 'Needs review' merge proposal status text should be
a link to the merge proposal itself.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11-02-24 04:33 AM, Jamu Kakar wrote:
> I was just about to file a bug about this when I found that it's
> already been filed. I often end up having to drive around Launchpad
> to figure out if the prerequisite listed on a merge proposal is merged
> or not. I'd like to see something like:
>
> Proposed branch: lp:~jkakar/project/proposed-branch
> Merge into: lp:project
> Prequisite branch: lp:~jkakar/project/prerequisite-branch (Needs review)

For myself, I'd like to see a list of the prerequisite merge proposals
and the dependent merge proposals. Something like:

prereq 1 <- prereq 2 <- current -> dependent 1 -> dependent 2
                                               -> dependent 3

That could incorporate status as well, I suppose.

> I suppose listing the merge proposal status gets tricky when
> a branch has more than one merge proposal

For a given target branch, there can be only one active merge proposal.
 It is trickier if you want to show inactive merge proposals (e.g.
merged, superseded).

> Anyway, the primary thing I want to know when a prerequisite branch is
> listed is whether or not I need to pull it to diff the proposed branch
> against.

Why do you want to do a diff? We already provide diffs.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1m1sYACgkQ0F+nu1YWqI1c9ACfQhpvvt7noqL9Kr+Oz5AH5Eg1
Q2QAnRome6aR6y1rrFy74PYQ5Rt0GOBP
=IP0c
-----END PGP SIGNATURE-----

Changed in launchpad:
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers