Comment 3 for bug 414482

We have had a number users complaining about uploads not appearing:

{{{
<thomas> I tried sending a package up to ppa with dput yesterday and it seemed to go well but it never appeared in my ppa. I try now again to dput and it just says "Already uploaded to ppa on ppa.launchpad.net". What is my next step? My key is good because I was able to sign the "code of conduct"
<thomas> I never got an email either..
<noodles775> thomas: which PPA, and have you read:
<thomas> my dput command is "dput ppa:thomas-chaniel/ppachaniel lazy8ledger_2.24-0ubuntu1_source.changes
<thomas> "
<noodles775> https://answers.edge.launchpad.net/soyuz/+faq/227
<noodles775> ok, looking
<thomas> Thanks for the link. The guys yesterday gave me that link and I believe I have followed everything it says there.
<noodles775> thomas: great, I'll check the logs...
<noodles775> thomas: ok, we're getting exceptions after the upload finishes... I'm looking now and well get back to you. Sorry about that.
<thomas> ok..
<noodles775> losa: can you please restart poppy? we seem to have an occurrence of bug 414482
<ubottu> Launchpad bug 414482 in soyuz "upload daemon poppy dies often" [Medium,Triaged] https://launchpad.net/bugs/414482
}}}

The poppy.log seems to show a *lot* of
{{{
2009-12-22 09:04:06 ERROR Exception during client done hook
Traceback (most recent call last):
  File "/srv/launchpad.net/codelines/ppa-rev-8806/lib/canonical/poppy/server.py", line 141, in clientFinished
    self.client_done_hook(channel.fsroot, clienthost, clientport)
  File "/srv/launchpad.net/codelines/ppa-rev-8806/lib/lp/archiveuploader/poppyinterface.py", line 45, in client_done_hook
    raise PoppyInterfaceFailure("Unable to find fsroot in client set")
PoppyInterfaceFailure: Unable to find fsroot in client set
}}}

Scarily, poppy seems to have been in this state for a few days, looking at the logs. Tom restarted poppy and it seems to have gone back to normal.

Looking at the code, it seems that we should only be in this state if either:
1) client_hook_done was called before new_client_hook (we could update the log message during the poppy interface failure to print the fsroot, which would give us a way of checking), or
2) the internal state (PoppyInterface.clients) was being corrupted after new_client_hook.

As the irc comment above suggests, the users pkg has been uploaded, and cannot be re-uploaded, but there are no records on the PPA for it.