It was decided during the last ui/wording review that it was necessary -
but perhaps it doesn't need to be so prominent. I've moved it and
made it an aside... see what you think.
I'm not sure that changing the ordering of the actions is helpful - as it
would require explicit overiding of LPForm's standard rendering (actions +
cancel). But renaming to 'Cancel access' to 'Revoke access' is a great idea
and is much clearer...
Unfortunately I can't, as this is controlled by the widget itself - and afaics
the widget sometimes uses this space - so it would need to be fixed there.
That said, I was able to improve the situation by ensuring the first column
is a bit wider.
> - The edit/cancel buttons are on a separate column than the names, and very far away. Is there a reason for it?
Yes, the initial screenshot did not use the optional comment or expiry date
fields. Look at the screencast below.
> - I wonder if we need to make it clearer that the top row is for adding, and maybe add a little bit of vertical spacing with the names?
>
OK, I've added a bit of JS, so that if JS is enabled, the add-subscriber
row is actually hidden and an 'Add subscriber' link is presented. I also
added a slight background colour to differentiate the row when it is
visible. Again, see what you think.
I forgot to mention during the screencast, I tried using the Lazr slider, but
it doesn't currently work with tables as it sets display:block, where as
a table row requires display:table-row.
Yes, we (you even? ;) ), decided that it would be too easy to confuse it for
a link to the actual subscription (given that it's in the first column of
a table listing the subscriptions.
A while ago, Martin wrote: people. canonical. com/~michaeln/ archive- subscription- mechanical- 3-0/Screenshot- Access% 20to%20PPA% 20for%20Celso% 20Providelo% 20-%20Mozilla% 20Firefox. png
> The mechanical changes look fine, but I'm taking this opportunity to make some comments on the existing layouts:
>
> http://
>
> - Do we need so much text for the password section?
It was decided during the last ui/wording review that it was necessary -
but perhaps it doesn't need to be so prominent. I've moved it and
made it an aside... see what you think.
http:// people. canonical. com/~michaeln/ 409187/ 1-Screenshot- AccesstoPPAforC elsoProvidelooC hromium. png
> - Shouldn't the title of that section actually be "Generate new password"? Maybe it should be "Reset password"?
Updated wording to 'Reset password'.
> people. canonical. com/~michaeln/ archive- subscription- mechanical- 3-0/Screenshot- Edit%20Celso% 20Providelo% 27s%20access% 20to%20PPA% 20for%20Celso% 20Providelo% 20-%20Mozilla% 20Firefox. png
> http://
>
> "Save" - "Cancel access" or "cancel" seems odd.
> How about "Save" - "cancel", and have a separate section that's "Revoke access", which just has a phrase explaining what it does, and the button?
>
> Another alternative is:
>
> "Save" - "cancel"
>
> OR
>
> "Revoke access"
I'm not sure that changing the ordering of the actions is helpful - as it
would require explicit overiding of LPForm's standard rendering (actions +
cancel). But renaming to 'Cancel access' to 'Revoke access' is a great idea
and is much clearer...
http:// people. canonical. com/~michaeln/ 409187/ 2.Screenshot- editPPAforCelso ProvidelooeCels oProvideloChrom ium.png
> people. canonical. com/~michaeln/ archive- subscription- mechanical- 3-0/Screenshot- Manage% 20access% 20to%20PPA% 20for%20Celso% 20Providelo% 20-%20Mozilla% 20Firefox. png
> http://
>
> - I think you should replace the spaces between the inputs and the "Choose" links with a so it doesn't break like that
Unfortunately I can't, as this is controlled by the widget itself - and afaics
the widget sometimes uses this space - so it would need to be fixed there.
That said, I was able to improve the situation by ensuring the first column
is a bit wider.
> - The edit/cancel buttons are on a separate column than the names, and very far away. Is there a reason for it?
Yes, the initial screenshot did not use the optional comment or expiry date
fields. Look at the screencast below.
> - I wonder if we need to make it clearer that the top row is for adding, and maybe add a little bit of vertical spacing with the names?
>
OK, I've added a bit of JS, so that if JS is enabled, the add-subscriber
row is actually hidden and an 'Add subscriber' link is presented. I also
added a slight background colour to differentiate the row when it is
visible. Again, see what you think.
http:// people. canonical. com/~michaeln/ 409187/ 3.p3a-grant- access. ogv
I forgot to mention during the screencast, I tried using the Lazr slider, but
it doesn't currently work with tables as it sets display:block, where as
a table row requires display:table-row.
> http:// people. canonical. com/~michaeln/ archive- subscription- mechanical- 3-0/Screenshot- Private% 20PPA%20access% 20-%20Mozilla% 20Firefox. png
>
> - Any reason why "PPA for Celso..." isn't a link, and there's a "View" link on the far right?
>
Yes, we (you even? ;) ), decided that it would be too easy to confuse it for
a link to the actual subscription (given that it's in the first column of
a table listing the subscriptions.