Comment 2 for bug 392356

Revision history for this message
Jonathan Lange (jml) wrote : Re: [Bug 392356] [NEW] Individuals +activereviews page should be the same for all viewers

On Fri, Jun 26, 2009 at 2:02 PM, Martin Albisetti<email address hidden> wrote:
> On Thu, Jun 25, 2009 at 10:19 PM, Jonathan Lange<email address hidden> wrote:
>> Public bug reported:
>>
>> Branch visibility aside, the +activereviews page for an individual
>> should show the same breakdown of "Reviews Person needs to do", "Reviews
>> Person is waiting on" and "Reviews Person has done" that is currently
>> shown when you look at your own +activereviews page.
>
> What's the difference now?
> In general, I think we should move more towards pages that are more
> adapted to the person looking at it. The argument that it's harder to
> debug is kinda boring.
>

I hope I didn't use that argument, since I agree with your general point.

If you look at the attached screenshot, you'll see what I see when I
look at my +activereviews page. However, if a random user looks at
https://code.edge.launchpad.net/~jml/+activereviews, they'll see
everything in one list without a heading. If you, beuno, look at it,
you'll probably see one review in a "Reviews I have done" section, and
almost everything else in an "Other" section.

I personally think that it would be better if everyone saw what I saw,
except with "I" changed to "Jonathan Lange". Not because it's easier
to debug, but because it presents the raw data in a more interesting
fashion.

For example, when I go to your active reviews page, I'd rather see the
reviews you are waiting on than the reviews that you are doing that I
am waiting on. I can see the former quite easily on my own active
reviews page.

jml