Save & Continue button in Rosetta advances too much in changed-in-LP and new-suggestions filters

[Arne Goetje]

With mutating filters (i.e. while you are editing translations, you are removing them from that filter) on +translate pages, only untranslated filter works correctly.

Other filters (changed_in_launchpad, new_suggestions) do not adjust last ID properly and instead skip batch size of items when you "Save & Continue", even if you removed some items from the batch.

We should do the same trick for those filters as we do it for untranslated.

[Данило Шеган (danilo)]

Arne, I am assuming you are talking about using 'untranslated' filter, right?

This seems to have been broken when batchnavigator changes were introduced. This likely applies to other filters where batches can mutate (i.e. changed in LP, new suggestions).

[Данило Шеган (danilo)]

Actually, I can't reproduce this on staging on eg. https://translations.staging.launchpad.net/limewire/trunk/+pots/limewire/sr/+translate?show=untranslated&start=0

Arne, can you please point me at where did you see this happen?

[Arne Goetje (arnegoetje)]

https://translations.edge.launchpad.net/ubuntu/jaunty/+source/gtk+2.0/+pots/gtk20/sr/+translate?show=changed_in_launchpad

This page shows 1-10 of 86 entries
If you make a change (for example, correct the first entry shown in this page ;) ) then hit "Save & Continue", the next page will count down the number of total items (86 minus the ones you fixed already) and advance to entries 11-20. Now, to make this example easy, assume you fix all 10 entries on the first page. Once you save your changes, they get subtracted from the filter result, hence the number of total entries will be reduced to 76 in this case. Now the expected behavior (as the filter results get refreshed) would be to display entries 1-10 of 76 (the other 10, which you have fixed already have fallen out of the filter result already). But what it does is, it advances by 10 entries to display entries 11 to 20 of 76. That means the now entries 1 to 10 are left behind. The translator would need to hit the "First" link to see the 10 entries which have been jumped over.
If the translator does not go back to the first 10 entries, but continues with entries 11-20 and fixes all 10 entries again, the next page will show entries 21-30 of 66 (means the first 20 entries are jumped over).

[Данило Шеган (danilo)]

So this happens with changed_in_launchpad and new_suggestions filters. untranslated filter works fine, as I mentioned earlier (which is why I didn't see the problem). Arne, thanks for nailing it down!

[Robert Collins (lifeless)]

Using the new storm batch factory would fix this as well as probably making higher batches faster to render.