LibraryFileAlias needs a fmt:url

Bug #36516 reported by Mark Shuttleworth
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

It would be nice to be able to link to a libraryfile just using foo/file/fmt:url like all the other things in LP, rather than the custom foo/file/url. It's a tiny difference but it would make LibraryFileAlias'es similar to everything else.

Changed in launchpad:
assignee: nobody → stevea
Revision history for this message
James Henstridge (jamesh) wrote :

It looks like special casing would be necessary to get canonical_url() (fmt:url is just a wrapper for this function) to return the librarian URL.

I wonder if there are any other objects for which an external URL would make more sense to return? I suspect that they'd need to be unreachable as URLs under https://launchpad.net/ though, or it might cause problems with navigation.

Revision history for this message
Mark Shuttleworth (sabdfl) wrote : Re: [Bug 36516] LibraryFileAlias needs a fmt:url

Is special-casing required because the external librarian URL's are not
"cascading" like other Launchpad internal URL's? Steve, do you think
this is still feasible?

Revision history for this message
Steve Alexander (stevea) wrote :

The librarian is a part of launchpad. It makes sense to use fmt:url and canonical_url with librarian URLs. The librarian's base URL is available from the launchpad configuration file. This is all the same system, really.

The "cascading" thing ought to be just an optimisation; a convenience. It does allow us to do various kinds of inspection for auto-testing pages and things, so I want to keep it around in most cases. We can choose not to use it for librarian urls, though.

I don't want to use fmt:url for URLs that are truely external to launchpad. I think this would lead to confusion.

Changed in launchpad:
status: Unconfirmed → Confirmed
Curtis Hovey (sinzui)
Changed in launchpad-foundations:
assignee: Steve Alexander (stevea) → nobody
Curtis Hovey (sinzui)
tags: added: tales
Curtis Hovey (sinzui)
affects: launchpad-foundations → launchpad-web
Revision history for this message
Robert Collins (lifeless) wrote :

Still valid I think, but not currently on anyones plate nor slated to be.

Changed in launchpad:
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.