Comment 5 for bug 352094

Revision history for this message
Jonathan Lange (jml) wrote : Re: [Bug 352094] Re: Expose ISourcePackage.branches

On Fri, Oct 23, 2009 at 7:22 PM, Muharem Hrnjadovic
<email address hidden> wrote:
> Hmm .. interesting. IMHO the `ISeriesSourcePackageBranch` class has
> nothing to it that would preclude it from external exposure. Why is it
> banned from all APIs?
>

Because it's a boring implementation detail of no actual use. It's
sole purpose is to allow us to associate a mapping from pocket ->
branch with each source package.

If we weren't using an ORM, it wouldn't be a class at all.

> The ISourcePackage.linked_branches() method returns a collection of
>
>   (SeriesSourcePackageBranch.pocket, Branch) tuples
>
> which makes it difficult to declare its return type using something like
> @operation_returns_collection_of(). Or am I missing something?
>

TBH, I'm not sure why it's a list of tuples rather than a dict. I
don't know how to expose a dict over the API. Surely someone has done
it before though.

jml