exceptions accepting single uploads shouldn't crash the whole publisher
Bug #33688 reported by
Colin Watson
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Jelmer Vernooij | ||
Bug Description
Recently we've had a couple of errors processing single uploads that crashed the entire publisher and required me to phone people and take them away from what they would otherwise have been doing on a Saturday. In both cases (one was due to the rare case of multiple custom upload entries in a .changes file, another due to a zero-length .pot file), it seems unnecessary for these failures to take out the entire publisher for many hours. Could the publisher catch these errors, report them somewhere, and carry on?
(this occurs in process-accepted)
Related branches
lp:~jelmer/launchpad/robust-process-accepted
- Henning Eggers (community): Approve (code)
-
Diff: 156 lines (+68/-18)2 files modifiedlib/lp/soyuz/scripts/processaccepted.py (+13/-5)
lib/lp/soyuz/tests/test_processaccepted.py (+55/-13)
| description: | updated |
| Changed in launchpad-upload-and-queue: | |
| assignee: | nobody → cprov |
| status: | Unconfirmed → Confirmed |
Revision history for this message
| Celso Providelo (cprov) wrote | #1 |
| Changed in soyuz: | |
| milestone: | none → 2.1.11 |
| status: | Confirmed → Triaged |
| Changed in soyuz: | |
| assignee: | cprov → nobody |
| Changed in soyuz: | |
| milestone: | 2.1.11 → 2.1.12 |
| Changed in soyuz: | |
| milestone: | 2.1.12 → pending |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #2 |
| Changed in soyuz: | |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| Changed in soyuz: | |
| status: | Triaged → In Progress |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #3 |
| Changed in soyuz: | |
| milestone: | pending → 10.04 |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
It happened again today, time to do something about it.