Comment 5 for bug 239864

Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 239864] Re: request merge should send an email

On Tuesday 19 August 2008 11:43:17 Jonathan Lange wrote:
> On Tue, Aug 19, 2008 at 9:07 AM, Tim Penhey <email address hidden> wrote:
> > There was the explicit design decision not to send implicit emails, but
> > instead to implicitly subscribe the branch owner (although it has been
> > argued that we should subscribe only the branch registrant), and that
> > way the owner can unsubscribe if they really don't want to get emails.
> > One of the fields that can be set for a branch subscription is the
> > amount of code review email the subscriber wants.
>
> I haven't ever received email for someone creating a merge proposal
> one of my branches. This makes the feature less useful to me, because
> it means I have to keep checking all my trunks.

That is probably due to when we made this change, we didn't go and
create subscriptions for all existing branches. Branches created before
the change don't have the implicit subscribers, so you'd have to go and
subscribe to your own trunks.

Tim