Comment 39 for bug 191199

Revision history for this message
In , Frédéric Buclin (lpsolit-deactivatedaccount) wrote :

(In reply to comment #37)
> Well, that's the real question, I suppose: "display" vs. "consume".

If I type "& means & in HTML" in a comment, I want it to be set back to this exact string after the XML parser has read the XML file. I don't want the XML parser to convert it back to "& means & in HTML". So when you generate the XML file, you should encode & in all cases, and not assume that the input data was already escaped.

About illegal characters, as philor says we have no way to pass them due to limitations of the XML 1.0 spec, I think it's better to silently skip them as it's very unlikely that we will "see" them anyway.

So simply remove the first part of your patch about & and re-request review.