buildrecipe incompatible with APT 1.1: Passes -y to a command not supporting it

[Julian Andres Klode]

python-apt from the APT upstream PPA FTBFS (which includes APT 1.1) using the daily recipe due to:

RUN: /usr/share/launchpad-buildd/slavebin/buildrecipe ['buildrecipe', 'RECIPEBRANCHBUILD-1028640', 'Launchpad Package Builder', '<email address hidden>', 'wily', 'wily', 'universe', 'PPA']
E: Command line option 'y' [from -y] is not understood in combination with the other options.
RUN: /usr/share/launchpad-buildd/slavebin/scan-for-processes ['scan-for-processes', 'RECIPEBRANCHBUILD-1028640']
Scanning for processes to kill in build /home/buildd/build-RECIPEBRANCHBUILD-1028640/chroot-autobuild...
RUN: /usr/share/launchpad-buildd/slavebin/umount-chroot ['umount-chroot', 'RECIPEBRANCHBUILD-1028640']
Unmounting chroot for build RECIPEBRANCHBUILD-1028640...
RUN: /usr/share/launchpad-buildd/slavebin/remove-build ['remove-build', 'RECIPEBRANCHBUILD-1028640']
Removing build RECIPEBRANCHBUILD-1028640

Full build log:

https://launchpadlibrarian.net/227870960/buildlog.txt.gz

So, it seems that Launchpad passes -y to an apt-get subcommand not expecting it.

[Colin Watson (cjwatson)]

20:46 <juliank> It seems that merging APT 1.1 will cause PPA building from recipes to fail: https://bugs.launchpad.net/launchpad/+bug/1520827
20:46 <ubottu> Launchpad bug 1520827 in Launchpad itself "PPAs or recipes incompatible with APT 1.1: Passes -y to a command not supporting it" [Undecided,New]
20:52 <cjwatson> juliank: buildrecipe uses "apt-get install -y lsb-release" and "apt-get build-dep -y --only-source <package>". Do you know which it is?
20:53 <cjwatson> juliank: And that seems like a reasonably alarming incompatibility - I think both those forms are quite commonplace?
20:53 <juliank> cjwatson: Both work for me, so it must be something else
20:54 <cjwatson> juliank: From the log, I think it must be the first of those
20:54 <juliank> Well, install -y must work. It's used by the test suite.
20:55 <cjwatson> It'll be passed through sudo, but surely that hasn't changed
20:56 <cjwatson> The full command line will be /usr/bin/sudo /usr/sbin/chroot <path to chroot> apt-get install -y lsb-release
20:57 <juliank> cjwatson: And in fact, a previous build worked like that one: https://launchpad.net/~deity/+archive/ubuntu/sid/+build/8350920
20:57 <juliank> or rather that one: https://launchpad.net/~deity/+archive/ubuntu/sid/+recipebuild/1028125
20:58 <juliank> cjwatson: Maybe I should try reissuing the build?
20:58 <juliank> Maybe some bits flipped in memory
20:58 <cjwatson> I suppose you can try, but it seems like a rather startling coincidence
20:59 <juliank> Well, there were not many changes in APT between the two builds
20:59 <cjwatson> The difference is from apt 1.1+2790~ubuntu15.10.1 to 1.1.1+2803~ubuntu16.04.1
20:59 <cjwatson> Anyway, by all means retry, it's cheap

[Julian Andres Klode (juliank)]

Sorry for the noise. It turns out that this is due to weak symbol usage for command line parser in libapt-private and Ubuntu using -Bsymbolic-functions which caused the APT build to bind calls to the weak symbols to their weak definitions.