Git merge proposals can't be linked to bugs
Bug #1492926 reported by
Po-Hsu Lin
This bug affects 5 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
For the bzr, I can link it to a bug with --fixes=lp:1484042 while committing changes, or manually link it later on the branch page.
But I can't do this with git, it will be great to have an equivalent feature with git, or even just with the capability to link bugs on the branch page.
Thanks
Related branches
lp:~cjwatson/launchpad/bmp-buglinktarget
- William Grant: Approve (code)
- Celso Providelo (community): Approve
-
Diff: 255 lines (+101/-38)4 files modifiedlib/lp/code/interfaces/branchmergeproposal.py (+2/-1)
lib/lp/code/model/branchmergeproposal.py (+48/-11)
lib/lp/code/model/tests/test_branchmergeproposal.py (+46/-25)
lib/lp/code/stories/webservice/xx-branchmergeproposal.txt (+5/-1)
lp:~cjwatson/launchpad/bmp-buglinktarget-git
- William Grant: Approve (code)
- Celso Providelo (community): Approve
-
Diff: 718 lines (+261/-47)16 files modifieddatabase/schema/security.cfg (+2/-0)
lib/lp/_schema_circular_imports.py (+2/-1)
lib/lp/bugs/configure.zcml (+3/-1)
lib/lp/bugs/interfaces/bug.py (+30/-5)
lib/lp/bugs/interfaces/bugtasksearch.py (+7/-3)
lib/lp/bugs/model/bug.py (+40/-2)
lib/lp/bugs/model/bugtasksearch.py (+27/-3)
lib/lp/bugs/model/tests/test_bug.py (+31/-1)
lib/lp/bugs/model/tests/test_bugtasksearch.py (+6/-4)
lib/lp/bugs/tests/buglinktarget.txt (+1/-1)
lib/lp/bugs/tests/test_buglinktarget.py (+13/-3)
lib/lp/code/model/branchmergeproposal.py (+34/-8)
lib/lp/code/model/gitcollection.py (+9/-4)
lib/lp/code/model/tests/test_branchmergeproposal.py (+29/-3)
lib/lp/code/model/tests/test_gitcollection.py (+16/-1)
lib/lp/services/xref/interfaces.py (+11/-7)
lp:~cjwatson/launchpad/bug-bmp-activity
- William Grant: Approve (code)
- Celso Providelo (community): Approve
-
Diff: 434 lines (+248/-18)8 files modifiedlib/lp/bugs/adapters/bugchange.py (+71/-11)
lib/lp/bugs/configure.zcml (+9/-0)
lib/lp/bugs/doc/malone-karma.txt (+9/-1)
lib/lp/bugs/model/bugactivity.py (+5/-1)
lib/lp/bugs/scripts/bugnotification.py (+3/-2)
lib/lp/bugs/subscribers/bugactivity.py (+26/-1)
lib/lp/bugs/subscribers/karma.py (+11/-1)
lib/lp/bugs/tests/test_bugchanges.py (+114/-1)
lp:~cjwatson/launchpad/bmp-buglinktarget-ui
- William Grant: Approve (code)
- Celso Providelo (community): Approve
-
Diff: 850 lines (+436/-44)17 files modifiedlib/lp/_schema_circular_imports.py (+6/-0)
lib/lp/bugs/browser/bugtask.py (+6/-0)
lib/lp/bugs/browser/tests/test_bugtask.py (+5/-5)
lib/lp/bugs/interfaces/bug.py (+21/-0)
lib/lp/bugs/templates/bug-branch.pt (+6/-0)
lib/lp/bugs/templates/bugtask-index.pt (+13/-2)
lib/lp/code/browser/branchmergeproposal.py (+9/-5)
lib/lp/code/browser/configure.zcml (+12/-0)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+143/-3)
lib/lp/code/interfaces/branchmergeproposal.py (+18/-0)
lib/lp/code/javascript/branch.bugspeclinks.js (+15/-4)
lib/lp/code/javascript/tests/test_bugspeclinks.js (+38/-12)
lib/lp/code/stories/branches/xx-branchmergeproposals.txt (+14/-9)
lib/lp/code/templates/branch-macros.pt (+4/-0)
lib/lp/code/templates/branchmergeproposal-macros.pt (+66/-0)
lib/lp/code/templates/branchmergeproposal-pagelet-summary.pt (+33/-4)
lib/lp/code/templates/branchmergeproposal-unlinkbugs.pt (+27/-0)
lp:~cjwatson/launchpad/git-update-related-bugs
- Celso Providelo (community): Approve
- Launchpad code reviewers: Pending requested
-
Diff: 879 lines (+485/-35)16 files modifiedlib/lp/answers/model/question.py (+6/-3)
lib/lp/blueprints/model/specification.py (+5/-3)
lib/lp/bugs/interfaces/buglink.py (+2/-2)
lib/lp/bugs/model/buglinktarget.py (+4/-4)
lib/lp/bugs/model/cve.py (+5/-3)
lib/lp/code/interfaces/branchmergeproposal.py (+6/-0)
lib/lp/code/interfaces/gitrepository.py (+5/-2)
lib/lp/code/model/branchmergeproposal.py (+89/-4)
lib/lp/code/model/gitrepository.py (+2/-1)
lib/lp/code/model/tests/test_branchmergeproposal.py (+143/-0)
lib/lp/code/model/tests/test_gitjob.py (+1/-0)
lib/lp/code/model/tests/test_gitref.py (+175/-0)
lib/lp/code/model/tests/test_gitrepository.py (+33/-9)
lib/lp/code/subscribers/branchmergeproposal.py (+4/-3)
lib/lp/code/subscribers/git.py (+1/-1)
lib/lp/services/config/schema-lazr.conf (+4/-0)
Revision history for this message
| Colin Watson (cjwatson) wrote | #1 |
| tags: | added: feature git |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| summary: |
- Link the git branch to a bug + Git merge proposals can't be linked to bugs |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| status: | Triaged → In Progress |
| Changed in launchpad: | |
| assignee: | William Grant (wgrant) → Colin Watson (cjwatson) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #4 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #5 |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #6 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Colin Watson (cjwatson) wrote | #7 |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
We'd like to do something about this, although we've yet to figure out exactly what. Git branches are often rather more ephemeral than Bazaar branches, and we're a little wary of putting overly-strong linkages into the database that could make them harder to delete. It might involve some combination of a commit scanner to scan for some kind of pattern in commit messages that identifies bugs (GitHub and other sites do something like this), or linking bugs to merge proposals rather than to branches.