URLs ending with a ) aren't linkified properly

[Cesare Tirabassi]

In this answer:

https://answers.launchpad.net/ubuntu/+source/gnome-games/+question/7531

the string http://en.wikipedia.org/wiki/Robots_(computer_game) has been transformed into a URL but with the wrong address (the final parenthesis is missing).

I checked this in the page source, and it is indeed reported as:

href="http://en.wikipedia.org/wiki/Robots_(computer_game"

[Cesare Tirabassi (norsetto)]

Well, same piece of software, some bug ... also in this page :)

[Francis J. Lacoste (flacoste)]

This is a bug with the linkifier code.

[Cesare Tirabassi (norsetto)]

My guess is that this is on purpose. When the ) is parsed it is not linkified; that's because the link could actually be between parenthesis (http://this.is.linkified/correctly). Perhaps the logic could be improved so that if a ( is included in the address than a following ) should also be considered part of the address.
Of course, an address like this: http://this.is.a.really/stupid.address) will not be linkified and most probably deserves not to be...

[Stuart Bishop (stub)]

It was deliberately done this way, but the suggestion of looking for opening
brackets in the URL sounds like an improvement.

[James Henstridge (jamesh)]

Not linkifying the closing parenthesis was a concious decision for the reason Cesare gave. This is probably the reason that the links Wikipedia generates for such pages look like http://en.wikipedia.org/wiki/Robots_%28computer_game%29 (which does link correctly).

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12102 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12102>.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12121 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12121>.

[Данило Шеган (danilo)]

Tested this on qastaging: https://bugs.qastaging.launchpad.net/intltool/+bug/664541

[Данило Шеган (danilo)]

We shouldn't clear up bad-commit-12102 tag until all of revisions up to (and including) 12121 have "cleared" for landing (fwiw, I am interested in this simply because I have an OOPS fix for roughly a 1000 of OOPSes a day :).

[j.c.sackett (jcsackett)]

Everything through r12121 is good to go now, so we can kill bad-commit.