soyuz emails are vague about why they are being sent to a given user
Bug #117155 reported by
Julian Edwards
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
After the upload-
You are receiving this email because you are the uploader, maintainer or
signer of the above package.
which is good, but not optimal. It's best if the rationale is customised based
on the recipient. We have a helper class INotificationRe
be used to implement this.
See also bug #3797.
Related branches
lp:~cjwatson/launchpad/upload-mail
- William Grant (community): Approve (code)
-
Diff: 3299 lines (+1182/-1013)22 files modifiedlib/lp/archiveuploader/tests/nascentupload-announcements.txt (+54/-53)
lib/lp/archiveuploader/tests/test_ppauploadprocessor.py (+62/-72)
lib/lp/archiveuploader/tests/test_sync_notification.py (+5/-5)
lib/lp/archiveuploader/tests/test_uploadprocessor.py (+111/-98)
lib/lp/services/mail/basemailer.py (+6/-1)
lib/lp/services/mail/notificationrecipientset.py (+29/-5)
lib/lp/soyuz/doc/distroseriesqueue-notify.txt (+99/-56)
lib/lp/soyuz/doc/soyuz-set-of-uploads.txt (+15/-14)
lib/lp/soyuz/emailtemplates/ppa-upload-accepted.txt (+0/-4)
lib/lp/soyuz/emailtemplates/ppa-upload-rejection.txt (+0/-4)
lib/lp/soyuz/emailtemplates/upload-accepted.txt (+0/-4)
lib/lp/soyuz/emailtemplates/upload-new.txt (+0/-4)
lib/lp/soyuz/emailtemplates/upload-rejection.txt (+0/-4)
lib/lp/soyuz/mail/packageupload.py (+533/-535)
lib/lp/soyuz/mail/tests/test_packageupload.py (+205/-100)
lib/lp/soyuz/model/queue.py (+9/-6)
lib/lp/soyuz/scripts/packagecopier.py (+13/-10)
lib/lp/soyuz/scripts/tests/test_copypackage.py (+9/-17)
lib/lp/soyuz/stories/soyuz/xx-queue-pages.txt (+10/-6)
lib/lp/soyuz/tests/test_distroseriesqueue_debian_installer.py (+9/-3)
lib/lp/soyuz/tests/test_packagecopyjob.py (+7/-5)
lib/lp/soyuz/tests/test_packageupload.py (+6/-7)
| description: | updated |
| Changed in soyuz: | |
| status: | Unconfirmed → Confirmed |
| Changed in soyuz: | |
| importance: | Undecided → High |
| milestone: | none → pending |
| status: | Confirmed → Triaged |
| visibility: | private → public |
| summary: |
- Soyuz emails should describe better the reason for receiving them. + soyuz emails are vague about why they are being sent to a given user |
| Changed in launchpad: | |
| assignee: | nobody → Colin Watson (cjwatson) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
There are essentially three separate implicit subscriptions here, one for uploader, one for maintainer, one for signer, and if we had a notification service doing the actual sending this would just fall out from that.