Launchpad itself

Remove 'request feedback' feature for blueprints

Bug #1000642 reported by Данило Шеган
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Данило Шеган

Bug Description

The 'request feedback' feature on blueprints has never really been complete (or much used, for that matter).

For instance, emails are not sent when either the feedback is requested, nor when it is given (bug #3522).
It's also impossible to edit the feedback request, and they can only be found through the person's "requested feedback" page that nobody visits.

So, Francis has suggested getting rid of this functionality, and I jumped at the opportunity.

Fixing this bug should invalidate bug #3522, bug #3525, bug #51486, bug #125391, bug #125394, bug #125395, bug #588576 and bug #989740 (only partially).

See original description

Related branches

lp:~danilo/launchpad/kill-feedback-requests
Jelmer Vernooij (community): Approve
Diff: 1100 lines (+4/-748)
23 files modified
lib/lp/blueprints/browser/configure.zcml (+0/-19)
lib/lp/blueprints/browser/specification.py (+1/-23)
lib/lp/blueprints/browser/specificationfeedback.py (+0/-116)
lib/lp/blueprints/browser/specificationtarget.py (+0/-2)
lib/lp/blueprints/configure.zcml (+0/-9)
lib/lp/blueprints/enums.py (+0/-7)
lib/lp/blueprints/interfaces/specification.py (+0/-16)
lib/lp/blueprints/interfaces/specificationfeedback.py (+0/-45)
lib/lp/blueprints/model/specification.py (+0/-35)
lib/lp/blueprints/model/specificationfeedback.py (+0/-39)
lib/lp/blueprints/stories/blueprints/xx-reviews.txt (+0/-150)
lib/lp/blueprints/stories/standalone/xx-personviews.txt (+0/-13)
lib/lp/blueprints/templates/person-specfeedback.pt (+0/-31)
lib/lp/blueprints/templates/specification-givefeedback.pt (+0/-42)
lib/lp/blueprints/templates/specification-index.pt (+0/-16)
lib/lp/blueprints/templates/specification-listing-detailed.pt (+0/-6)
lib/lp/blueprints/templates/specification-listing-feedback.pt (+0/-36)
lib/lp/blueprints/templates/specification-portlet-feedbackqueue.pt (+0/-28)
lib/lp/blueprints/templates/specification-requestfeedback.pt (+0/-32)
lib/lp/registry/browser/configure.zcml (+0/-7)
lib/lp/registry/browser/person.py (+1/-22)
lib/lp/registry/doc/person.txt (+2/-11)
lib/lp/registry/model/person.py (+0/-43)
lp:~danilo/launchpad/bug-1000642-db
Stuart Bishop (community): Approve (db)
Robert Collins: Pending requested
Diff: 15 lines (+11/-0)
1 file modified
database/schema/patch-2209-20-0.sql (+11/-0)
lp:~danilo/launchpad/bug-1000642-drop
Stuart Bishop (community): Approve (db)
Diff: 98 lines (+9/-38)
4 files modified
database/sampledata/current-dev.sql (+0/-16)
database/sampledata/current.sql (+0/-16)
database/schema/comments.sql (+0/-6)
database/schema/patch-2209-20-1.sql (+9/-0)
Данило Шеган (danilo)
Changed in launchpad:
assignee: nobody → Данило Шеган (danilo)
status: New → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you for doing this. Doesn't this also fix Bug #125394, Bug #125395, Bug #588576, and Bug #989740
    https://bugs.launchpad.net/launchpad/+bugs?field.searchtext=feedback&field.tag=lp-blueprints

Changed in launchpad:
importance: Undecided → High
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in db-stable r11610 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/11610>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Данило Шеган (danilo) wrote :

This is only the database patch that has landed. Do we need to wait for it to be rolled out before we can land the actual code changes?

Thanks for finding those other bugs as well, Curtis. #989740 is only partially fixed by this ("Registrant" link still stays there), but it'd definitely be useful to update the bug once the fix for this ultimately lands.

Revision history for this message
Данило Шеган (danilo) wrote :

QA for this is ultimately the full test suite. No code has changed otherwise, it's just that the person merging will not insist on special handler being there for merging SpecificationFeedback rows.

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
William Grant (wgrant) wrote :

The DB patch must indeed be deployed first; to land the code before that would prevent further code rollouts until the patch was applied.

William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15399 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15399>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Данило Шеган (danilo) wrote :

This looks good, I played around and couldn't break anything on qastaging.

tags: added: qa-ok
removed: qa-needstesting
description: updated
Revision history for this message
William Grant (wgrant) wrote :

The code is gone. All that remains is dropping the DB table.

Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in db-stable r11732 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/11732>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
William Grant (wgrant) wrote :

From staging:

2012-07-04 01:17:20 INFO 2209-20-1 applied just now in 0.3 seconds

tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
Данило Шеган (danilo) wrote :

William, thanks for taking care of this for me.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.