committed code should update merge diff
Bug #392343 reported by
Chris S.
This bug report is a duplicate of:
Bug #338002: 'Review Diff' on merge proposal page can be out-of-date.
Edit
Remove
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Confirmed
|
Undecided
|
Unassigned |
Bug Description
When I propose to merge some code and Launchpad will generate a merge diff right on the merge proposal. It happens often that I end up pushing a new revision to the branch that I'm attempting to get merged. Sometimes the new commits to the branch are in direct response to comments on the merge review. In this case, it would be great if launchpad actually saw that there were new revisions to that branch and would generate a new merge diff to display on the merge proposal. As is right now, the merge diff is only against the code at the first revision that I proposed for merging.
affects: | launchpad → launchpad-code |
To post a comment you must log in.
I'm putting in another bug about a UI issue...but in the Drizzle project, we have come across this issue as well. Basically, here is what you need to do to get a new merge diff:
1) Click the little yellow edit icon next to the *status* of your original Merge proposal.
2) Select "Resubmit" from the dropdown list
3) Click "Change status"
4) Page will reload showing additional commits which will now be used in generating a new diff. Click "resubmit" button after reviewing these commit messages
5) Page will reload, *but will not have the new diff until you hit F5 or click the reload button on your browser*
Hope this helps!
Jay Pipes