'Review Diff' on merge proposal page can be out-of-date
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Aaron Bentley |
Bug Description
Today I created a merge proposal [1] for a Storm branch. James was
kind enough to review the branch for me and left a couple of review
comments that I implemented fixes for. I pushed new revisions, went
back to the merge proposal page to leave a comment about my changes
and noticed that the 'Review Diff' on the page was still showing the
original diff.
I figured it must be a latency issue, so I left my comment and
continue on.. After several hours, I checked the page again and was
surprised to see that the diff called 'Review Diff' was still
showing the original diff. I talked to Jonathan and Tim about it
and they explained that it was in fact expected behaviour. I think
it's actually misleading behaviour.
No one should review a branch without really getting it, running its
tests, exercising the changes, etc.; however, once this is done,
reviewing follow-on changes by looking at the diff on the web would
be convenient, but isn't possible with the current arrangement.
It's also misleading to web visitors to see a diff called 'Review
Diff' that isn't the diff that should actually be reviewed.
[1] https:/
Changed in launchpad-code: | |
assignee: | nobody → Aaron Bentley (abentley) |
milestone: | none → 3.0 |
status: | Triaged → In Progress |
Changed in launchpad-code: | |
status: | In Progress → Fix Released |
So, there's always lp:mad to automate the updates of the review diff, but there are no immediate plans to have Launchpad make a moving diff of both branches. As you can imagine, that can require a lot of heavy computational work if it was done on all launchpad projects.