$SHELL should be set in lxc containers building snaps

Bug #1716739 reported by Olivier Tilloy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
launchpad-buildd
High
Colin Watson

Bug Description

Following up on https://forum.snapcraft.io/t/launchpad-now-builds-snaps-in-lxd-containers-in-support-of-build-snaps/2002/18, it would be good to set $SHELL manually in the lxc containers used by launchpad to build snaps.

Some (arguably poor) assumptions made by some build systems expect $SHELL to be set, and will fail if not. This is the case of spidermonkey, the mozilla JS engine, a copy of which is embedded in 0AD.

Related branches

Olivier Tilloy (osomon)
summary: - $SHELL needs to be set in lxc containers building snaps
+ $SHELL should be set in lxc containers building snaps
Colin Watson (cjwatson)
Changed in launchpad-buildd:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Colin Watson (cjwatson)
Revision history for this message
Colin Watson (cjwatson) wrote :

launchpad-buildd (152) xenial; urgency=medium

  [ Colin Watson ]
  * Accept a "debug" entry in livefs arguments, which enables detailed
    live-build debugging.
  * Set SHELL=/bin/sh in snap builds, since it was previously passed through
    by the chroot backend and some build systems expect SHELL to be set
    (LP: #1716739).

  [ Robert C Jennings ]
  * LXD: Do not drop sys_rawio capability (LP: #1716060).

 -- Colin Watson <email address hidden> Wed, 13 Sep 2017 14:51:48 +0100

Changed in launchpad-buildd:
status: In Progress → Fix Released
Revision history for this message
Olivier Tilloy (osomon) wrote :

I confirm that with this fix in production, my 0AD snap builds fine. Thanks Colin!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers