$SHELL should be set in lxc containers building snaps
Bug #1716739 reported by
Olivier Tilloy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| launchpad-buildd |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
Following up on https:/
Some (arguably poor) assumptions made by some build systems expect $SHELL to be set, and will fail if not. This is the case of spidermonkey, the mozilla JS engine, a copy of which is embedded in 0AD.
Related branches
lp:~cjwatson/launchpad-buildd/snap-set-shell
- William Grant: Approve (code)
-
Diff: 150 lines (+23/-14)3 files modifieddebian/changelog (+3/-0)
lpbuildd/target/build_snap.py (+1/-0)
lpbuildd/target/tests/test_build_snap.py (+19/-14)
| summary: |
- $SHELL needs to be set in lxc containers building snaps + $SHELL should be set in lxc containers building snaps |
| Changed in launchpad-buildd: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Colin Watson (cjwatson) |
Revision history for this message
| Colin Watson (cjwatson) wrote | #1 |
| Changed in launchpad-buildd: | |
| status: | In Progress → Fix Released |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #2 |
To post a comment you must log in.
launchpad-buildd (152) xenial; urgency=medium
[ Colin Watson ]
* Accept a "debug" entry in livefs arguments, which enables detailed
live-build debugging.
* Set SHELL=/bin/sh in snap builds, since it was previously passed through
by the chroot backend and some build systems expect SHELL to be set
(LP: #1716739).
[ Robert C Jennings ]
* LXD: Do not drop sys_rawio capability (LP: #1716060).
-- Colin Watson <email address hidden> Wed, 13 Sep 2017 14:51:48 +0100