[1]
+ """A bpickle-compatbile argument."""
s/compatbile/compatible/
[2]
+ method_func = getattr(self.factory.object, method) + method_args = args[:] + method_kwargs = kwargs.copy()
I don't understand why args and kwargs are copied here. Is it necessary? Also, I removed the copying behaviour and no tests failed.
[3]
+ def __init__(self, reactor, socket):
Please call this socket_path to be extra clear about its purpose.
[4]
+ deferred = Deferred() + factory = self.factory(self._reactor, deferred.callback) + self._reactor.connectUNIX(self._socket, factory) + deferred.addCallback(self._connection_made) + return deferred
This means we're opening a connection per remote object, right? And each object will need it's own socket/path, right?
[5]
+ A L{RemoteObject} can send L{MethodCall}s without arguments and withj
s/withj/with/
This appears a few times.
It's looking good. I'm a bit concerned about #4, if I've understood the code correctly.
[1]
+ """A bpickle-compatbile argument."""
s/compatbile/ compatible/
[2]
+ method_func = getattr( self.factory. object, method)
+ method_args = args[:]
+ method_kwargs = kwargs.copy()
I don't understand why args and kwargs are copied here. Is it
necessary? Also, I removed the copying behaviour and no tests
failed.
[3]
+ def __init__(self, reactor, socket):
Please call this socket_path to be extra clear about its purpose.
[4]
+ deferred = Deferred() self._reactor, deferred.callback) connectUNIX( self._socket, factory) addCallback( self._connectio n_made)
+ factory = self.factory(
+ self._reactor.
+ deferred.
+ return deferred
This means we're opening a connection per remote object, right? And
each object will need it's own socket/path, right?
[5]
+ A L{RemoteObject} can send L{MethodCall}s without arguments and withj
s/withj/with/
This appears a few times.
It's looking good. I'm a bit concerned about #4, if I've understood
the code correctly.