Thanks Thomas, I'm +1 for this.
[1]
#if defined(__unix__) || defined(unix) || defined(__NetBSD__) || defined(__MACH__) /* Mac OS X */
The defined(__unix__) clause is duplicated. I'd suggest to drop the #if entirely, as we're not supporting architectures other than unix.
[2]
+def initgroups(uid, gid):
Would you mind adding a docstring to this function? Or even copy the Twisted one.
[3]
The package correctly contains the extensions, but if I install it I get:
$ python -c "import landscape.lib.initgroups" Traceback (most recent call last): File "<string>", line 1, in <module> ImportError: No module named initgroups
I'm not sure why this is happening.
Thanks Thomas, I'm +1 for this.
[1]
#if defined(__unix__) || defined(unix) || defined(__NetBSD__) || defined(__MACH__) /* Mac OS X */
The defined(__unix__) clause is duplicated. I'd suggest to drop the #if entirely, as we're not supporting architectures other than unix.
[2]
+def initgroups(uid, gid):
Would you mind adding a docstring to this function? Or even copy the Twisted one.
[3]
The package correctly contains the extensions, but if I install it I get:
$ python -c "import landscape. lib.initgroups"
Traceback (most recent call last):
File "<string>", line 1, in <module>
ImportError: No module named initgroups
I'm not sure why this is happening.