Package stays unknown forever in the client with hash-id-databases support

Bug #381356 reported by Andreas Hasenack on 2009-05-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Landscape Client
High
Free Ekanayaka

Bug Description

This package is unknown according to the logs:
2009-05-28 16:59:24,035 WARNING [MainThread] Package data not yet synchronized with server (183864)

But it is available:
sqlite> select * from available where id = 183864;
183864

And the server knows about it too, as I can select it for upgrades. smart sees it. And I forgot the rest of the description of this bug, but free is already fixing it :)

Changed in landscape-client:
assignee: nobody → Free Ekanayaka (free.ekanayaka)
importance: Undecided → High
milestone: none → 1.3.2
Changed in landscape-client:
status: New → In Progress
Free Ekanayaka (free.ekanayaka) wrote :

+1 from Gustavo (live review) and Andreas tested the patch and reported that it actually solves the issue.

tags: added: review
Thomas Herve (therve) wrote :

A couple of comments, but +1:

[1]
+ if hash:
+ return hash

"If hash is not None" looks like a better condition

[2]
+ the desidered mapping is not found.

Typo: desired?

[3] It would be nice to have a test when multiple HashIdStore are involved.

Thanks!

tags: removed: review

Thanks Thomas!

[1], [2] and [3]

Addressed.

 status fixcommitted

Changed in landscape-client:
status: In Progress → Fix Committed
Jamu Kakar (jkakar) on 2009-06-23
tags: added: needs-testing
Free Ekanayaka (free.ekanayaka) wrote :

This was tested "live" by Andreas during UDS, it still works on staging, qa +1.

tags: removed: needs-testing
Changed in landscape-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers