Package stays unknown forever in the client with hash-id-databases support

[Andreas Hasenack]

This package is unknown according to the logs:
2009-05-28 16:59:24,035 WARNING [MainThread] Package data not yet synchronized with server (183864)

But it is available:
sqlite> select * from available where id = 183864;
183864

And the server knows about it too, as I can select it for upgrades. smart sees it. And I forgot the rest of the description of this bug, but free is already fixing it :)

[Free Ekanayaka (free.ekanayaka)]

+1 from Gustavo (live review) and Andreas tested the patch and reported that it actually solves the issue.

[Thomas Herve (therve)]

A couple of comments, but +1:

[1]
+ if hash:
+ return hash

"If hash is not None" looks like a better condition

[2]
+ the desidered mapping is not found.

Typo: desired?

[3] It would be nice to have a test when multiple HashIdStore are involved.

Thanks!

[Free Ekanayaka (free.ekanayaka)]

Thanks Thomas!

[1], [2] and [3]

Addressed.

 status fixcommitted

[Free Ekanayaka (free.ekanayaka)]

This was tested "live" by Andreas during UDS, it still works on staging, qa +1.