[1] Nice docstrings -- thanks for adding those!
[2] The ticket mentions LANDSCAPE_ATTACHMENTS. But I don't see the env var for it getting cleaned up.
[3] Can you confirm (by experiment or second opinions) that closing the FDs is needed? It if is, I'd vote for a new branch/ticket...
As long as you're good on point [2], +1.
[1] Nice docstrings -- thanks for adding those!
[2] The ticket mentions LANDSCAPE_ ATTACHMENTS. But I don't see the env var for it getting cleaned up.
[3] Can you confirm (by experiment or second opinions) that closing the FDs is needed? It if is, I'd vote for a new branch/ticket...
As long as you're good on point [2], +1.