Comment 17 for bug 601816

Revision history for this message
X (u78qir8a9-deactivatedaccount) wrote :

David, I'm sorry that I haven't looked at this for such a long time, just like much of Kupfer. But I also came back to this bug last :-( hehe.. now, to business.

The patch looks good, but I have not been able to test the preedit functionality. I have installed ibus. How do I set it up to try?

Ok, now it certainly is *not* your fault that I have written messy, messy code in kupfer/ui/browser.py. This is the worst part of Kupfer.

Still, letting self.preedit thing ride on the set_active call felt strange.. No wonder it took me a while to understand that, the whole set_active/set_state stuff is superfluous anyway. I've produced an updated patch against today's master that uses a more explicit inject_preedit call. That also fixed up the changes in highlighting.

So then the important question is,
1) Does the patch still fulfill its purpose (with ibus) after my changes?
2) Does everything work like normal for other users (it definitiely seems like it)

Thanks for contributing this anyway, maybe some have already used it