Comment 12 for bug 1848775

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/803671
Committed: https://opendev.org/openstack/kolla-ansible/commit/767f1e4b2339aa84d241758e046c490bcf1a1d40
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 767f1e4b2339aa84d241758e046c490bcf1a1d40
Author: Radosław Piliszek <email address hidden>
Date: Fri Jul 31 17:54:52 2020 +0200

    Check config when checking the containers

    The proposed approach allows for checking whether config
    files are current, e.g. cases when the deployment was aborted after
    config files were generated but before they were injected into the
    containers which lead to old config staying in containers.

    After this patch we can do:
      kolla-ansible genconfig
      kolla-ansible deploy-containers
    and it would do what we expected rather than being a noop
    in the second part.

    We also lose the need to have notifies
    and whens in config and handler sections respectively.
    This is optimised in a separate patch.

    Future work:
    - optimise for large files
      - could we get away with comparing timestamps and sizes?
        container's should have a newer timestamp due to copy,
        could also preserve it

    Change-Id: I1d26e48e1958f13b854d8afded4bfba5021a2dec
    Closes-Bug: #1848775
    Depends-On: https://review.opendev.org/c/openstack/kolla/+/773257
    Co-Authored-By: Mark Goddard <email address hidden>
    (cherry picked from commit c3afbd3c5efb84a1df272bd44a46d4db60c69f0b)