Comment 2 for bug 2041859

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/899592
Committed: https://opendev.org/openstack/kolla-ansible/commit/7f01f47bdad93383a4e2b884c4216d7db925d67f
Submitter: "Zuul (22348)"
Branch: master

commit 7f01f47bdad93383a4e2b884c4216d7db925d67f
Author: Mark Goddard <email address hidden>
Date: Mon Oct 30 14:36:48 2023 +0000

    fact gathering: Group hosts before gathering facts

    If not using --limit, each host runs the setup module for itself only.
    Hosts should be able to fail at this point and drop out of execution
    without affecting others. However, there is a bug that causes us to hit
    the --limit code path for an unreachable host and therefore become
    subject to its limitations. These include the use of delegated fact
    gathering, and failing the delegated host when the delegating host is
    unreachable.

    This change fixes the issue by reversing the order of two tasks in the
    gather-facts.yml playbook, ensuring that we check the ansible_play_batch
    variable before any hosts have had a chance to fail.

    Change-Id: I4b1da63e8f0cc2774f1a9ab2e0414746108f7e12
    Closes-Bug: #2041859