Comment 28 for bug 1954925

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/878336
Committed: https://opendev.org/openstack/kolla-ansible/commit/300f584710c840e44ccf219f29f042338857e446
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 300f584710c840e44ccf219f29f042338857e446
Author: John Garbutt <email address hidden>
Date: Fri Dec 17 16:20:32 2021 +0000

    RabbitMQ: Support setting ha-promote-on-shutdown

    By default ha-promote-on-shutdown=when-synced. However we are seeing
    issues with RabbitMQ automatically recovering when nodes are restarted.
    https://www.rabbitmq.com/ha.html#cluster-shutdown

    Rather than waiting for operator interventions, it is better we allow
    recovery to happen, even if that means we may loose some messages.
    A few failed and timed out operations is better than a totaly broken
    cloud. This is achieved using ha-promote-on-shutdown=always.

    Note, when a node failure is detected, this is already the default
    behaviour from 3.7.5 onwards:
    https://www.rabbitmq.com/ha.html#promoting-unsynchronised-mirrors

    This patch adds the option to change the ha-promote-on-shutdown
    definition, using the flag `rabbitmq_ha_promote_on_shutdown`. This
    value is unset by default to avoid any unexpected changes to the
    RabbitMQ definitions.json file, as that would trigger an unexpected
    restart of RabbitMQ during the next deploy.

    Related-Bug: #1954925

    Change-Id: I2146bda2c72ddac2c9923c6941b0596395fd9ab5
    (cherry picked from commit 94f3ce0c78998e29fcc034a9b0844f9d6d602807)