commit d1b7814c76e309791353ad4a69ae6dfd14c75723
Author: Mark Goddard <email address hidden>
Date: Mon Oct 25 16:40:20 2021 +0100
nova: use any_errors_fatal for once-per-cell tasks
We run some nova tasks once per cell, using a condition to match a
single host in the cell. In other similar tasks, we use run_once, which
will fail all hosts if the task fails. Typically these tasks are
critical, and that is desirable. However, with the approach used in
nova-cell to support multiple cells, if a once-per-cell task fails, then
other hosts will continue to execute, which could lead to unexpected
results.
This change adds any_errors_fatal to the plays or blocks that run these
tasks.
Closes-Bug: #1948694
Change-Id: I2a5871ccd4e8198171ef3239ce95f475f3e4b051
(cherry picked from commit 832989d0a6ab9ba1380d559e0e532c17db82c2c6)
Reviewed: https:/ /review. opendev. org/c/openstack /kolla- ansible/ +/839173 /opendev. org/openstack/ kolla-ansible/ commit/ d1b7814c76e3097 91353ad4a69ae6d fd14c75723
Committed: https:/
Submitter: "Zuul (22348)"
Branch: stable/xena
commit d1b7814c76e3097 91353ad4a69ae6d fd14c75723
Author: Mark Goddard <email address hidden>
Date: Mon Oct 25 16:40:20 2021 +0100
nova: use any_errors_fatal for once-per-cell tasks
We run some nova tasks once per cell, using a condition to match a
single host in the cell. In other similar tasks, we use run_once, which
will fail all hosts if the task fails. Typically these tasks are
critical, and that is desirable. However, with the approach used in
nova-cell to support multiple cells, if a once-per-cell task fails, then
other hosts will continue to execute, which could lead to unexpected
results.
This change adds any_errors_fatal to the plays or blocks that run these
tasks.
Closes-Bug: #1948694
Change-Id: I2a5871ccd4e819 8171ef3239ce95f 475f3e4b051 1380d559e0e532c 17db82c2c6)
(cherry picked from commit 832989d0a6ab9ba