Comment 5 for bug 1868596

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/719954
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=8cc58e3669eec69f55269c54fc1de2a0b0c57c02
Submitter: Zuul
Branch: master

commit 8cc58e3669eec69f55269c54fc1de2a0b0c57c02
Author: Mark Goddard <email address hidden>
Date: Tue Apr 14 14:11:14 2020 +0100

    Fix service_mapped_to_host filter for common services

    In Ibecac60d1417269bbe25a280996ca9de6e6d018f, the services in the common
    role were marked as being mapped to the 'all' group, since the
    'service_mapped_to_host' filter expects every service definition to have
    either a 'group' or 'host_in_groups' field. While this allows the filter
    to pass the common services without error, it will not actually show
    them as being mapped to any hosts. This is because the filter uses the
    'group_names' variable, which contains all of the groups that a host
    belongs to, except the default 'all' group.

    This change fixes the issue by returning True from
    service_mapped_to_host when the service's group is 'all'.

    Change-Id: I39c8416f5d30a535c1743f9c43434b7d2a382196
    Related-Bug: #1868596