Comment 7 for bug 1843043

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.opendev.org/690589
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=65b27d772be32738a8508ea8e6c07f74f229cdb7
Submitter: Zuul
Branch: master

commit 65b27d772be32738a8508ea8e6c07f74f229cdb7
Author: Mark Goddard <email address hidden>
Date: Wed Oct 23 14:08:35 2019 +0100

    Fix mariabackup arguments

    After switching from innobackupex to mariabackup [1] for database
    backups, the kolla_mariadb_backup.sh script was not modified to account
    for the difference in arguments between innobackupex and mariabackup.
    There is a compatibility mode, the documentation [2] for which covers
    some of the differences.

    The following have been changed:

    - Add explicit --backup argument, now required
    - Remove './' positional argument - not required with --stream
    - Remove --no-timestamp argument - only supported in innobackupex
      compatibility mode
    - Remove --incremental argument - implied by --incremental-history-name
    - Remove deprecated --compress argument, which requires qpress to be
      installed (it is not). The stream is now passed through gzip instead
      [3]

    [1] https://mariadb.com/kb/en/library/mariabackup-overview/
    [2] https://mariadb.com/kb/en/library/mariabackup-options/#-innobackupex
    [3] https://mariadb.com/kb/en/library/using-encryption-and-compression-tools-with-mariabackup/

    Change-Id: I67cff47cbf56570b8eaeb66092dd87c2769fc8a6
    Closes-Bug: #1843043