Comment 14 for bug 1843043

Reviewed: https://review.opendev.org/692996
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=25890a485b20f9530f769c23af841d6a50593b37
Submitter: Zuul
Branch: stable/stein

commit 25890a485b20f9530f769c23af841d6a50593b37
Author: Marcin Juszkiewicz <email address hidden>
Date: Thu Sep 12 11:48:07 2019 +0200

    Stein: support mariabackup for backups

    This is a combination of 3 commits from Train. Rather than dropping
    xtrabackup, we are keeping it in addition to adding support for
    backups using mariabackup.

    1. Drop Percona XtraBackup in favour of MariaDB Backup

    XtraBackup started failing to install on Ubuntu and does not support
    MariaDB 10.3 version.

    Related-Bug: #1843043

    I9cf62c8e03a02574d85e5349df1d23a51d4c99be

    2. Fix mariabackup arguments

    After switching from innobackupex to mariabackup [1] for database
    backups, the kolla_mariadb_backup.sh script was not modified to account
    for the difference in arguments between innobackupex and mariabackup.
    There is a compatibility mode, the documentation [2] for which covers
    some of the differences.

    The following have been changed:

    - Add explicit --backup argument, now required
    - Remove './' positional argument - not required with --stream
    - Remove --no-timestamp argument - only supported in innobackupex
      compatibility mode
    - Remove --incremental argument - implied by --incremental-history-name
    - Remove deprecated --compress argument, which requires qpress to be
      installed (it is not). The stream is now passed through gzip instead
      [3]

    [1] https://mariadb.com/kb/en/library/mariabackup-overview/
    [2] https://mariadb.com/kb/en/library/mariabackup-options/#-innobackupex
    [3] https://mariadb.com/kb/en/library/using-encryption-and-compression-tools-with-mariabackup/

    I67cff47cbf56570b8eaeb66092dd87c2769fc8a6
    Closes-Bug: #1843043
    (cherry picked from commit 65b27d772be32738a8508ea8e6c07f74f229cdb7)

    3. Set pipefail in kolla_mariadb_backup.sh

    Without this, a failure in mariabackup would be ignored due to the pipe
    to gzip.

    I84536b302991e8fb04d5fa67ea266bc428437ce1
    Related-Bug: #1843043

    Change-Id: Idf1aed905a7d9ad461dd6fe17ed199c8d60370e6