Comment 5 for bug 1808805

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/791337
Committed: https://opendev.org/openstack/kolla-ansible/commit/aea9bf355058a15e7ce7bb2649de3872e7041c89
Submitter: "Zuul (22348)"
Branch: master

commit aea9bf355058a15e7ce7bb2649de3872e7041c89
Author: Scott Shambarger <email address hidden>
Date: Thu May 13 17:42:03 2021 -0700

    monasca-thresh: Fix topology submission to storm

    monasca-thresh currently runs a local copy of the storm
    to handle the threshold topology. However, it doesn't setup
    the environment correctly, and the executable fails, causing
    the container to continually restart.

    This patch updates the container command to correctly
    submit the topology to the running Apache storm. The
    container will exit after it finishes the submission,
    so the restart_policy is updated to on-failure, this way
    if the storm is temporarily unavailable, the submission
    will be retried. (NOTE: further deploys will see the
    container as "changed" as it won't be running)

    Patch uses KOLLA_BOOTSTRAP to trigger the container to
    check if the topology is already submitted, and if so skips
    the submission command so the container doesn't fail.

    The config task now triggers a new reconfigure handler that
    spawns a one-shot container to replace any existing topology
    if the configuration has changed.

    Also, all the storm.* variables in storm.yml.j2 are
    removed as they were only needed for local mode and
    make submitted topologies fail to load when the storm
    is restarted (the referenced directories not mounted
    on nimbus).

    Depends-On: https://review.opendev.org/c/openstack/kolla/+/792751
    Closes-Bug: #1808805
    Change-Id: Ib225d76076782d695c9387e1c2693bae9a4521d7