Comment 40 for bug 594073

Revision history for this message
Wayne Stambaugh (stambaughw) wrote : Re: [Bug 594073] Re: Highlight Nets

On 10/30/2016 8:04 AM, Nox_firegalaxy wrote:
> To avoid stalling maybe someone else can review the latest patch? If I
> am not mistaken, all objections except for the hotkeying should have
> been taken care of. The short cut can only be dealt with if a decision
> is made which way it should be handled.
>

I finally had a chance to test this it seems to work OK. I did not test
it on a complex hierarchy so maybe JP can take a look at that and
confirm that it works. One annoyance that I found is that on the first
net selection, the mouse warps back to the center of the drawing. This
needs to be fixed by setting the last position to the net selection
position but I'm fine if you do that as a separate patch.

There are a few coding policy issues that need to be resolved:

* Use "if( " not "if (" and "for( " not "for (".
* There are if statements on a single line. The body of the if
  statement must be on a separate line and indented.
* Your editor is leaving trailing white space.

Once the coding policy issues are cleaned up and I get confirmation that
it works on complex hierarchies, I will commit this.