Comment 38 for bug 594073
Revision history for this message
| Nox_firegalaxy (nox-7bitfaster) wrote Re: [Bug 594073] Re: Highlight Nets | #38 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Hi jean,
as you seems to be most experienced, can you please review the latest patch?
Thanks in advance,
Nox
Am 06.10.2016 um 18:26 schrieb jean-pierre charras:
> @nox,
> Thanks for your patch 05.
> this is better for complex hierarchies, but not yet fully working in more complex cases.
> The labels issue is not fixed.
>
> I am thinking you are using m_Flags to store the highlight status and this is not a good idea.
> m_Flags is intended to temporary store flags mainly during edition and calculations, not for status bits.
>
> You could try to use m_Status (GetState and SetState) to store the highlight status.
> Note also a similar status flag exists for Pcbnew (BRIGHTENED) and accessors are already existing (IsBrightened(), SetBrightened ... ), so perhaps no need to create a new flag for Eeschema.
>
> I uploaded a more complex hierarchy test (although this hierarchy is
> still basic) which shows highlight issues in the most inner sheets.
>
> Thanks for your work.
>
>
> ** Attachment added: "test_complex_
> https:/
>