Comment 32 for bug 594073

On 10/6/2016 9:24 AM, Chris Pavlina wrote:
> On Thu, Oct 06, 2016 at 01:02:02PM -0000, Wayne Stambaugh wrote:
>> On 10/6/2016 3:28 AM, Chris Pavlina wrote:
>>> Actually, on hotkeys:
>>>
>>> Having given this some thought, I disagree that it should have a
>>> *hotkey* (and that one should be added to pcbnew as well). GAL now has a
>>> shortcut for this, but it isn't a hotkey, it's ctrl-click. Since this
>>> was selected as the way to highlight nets in GAL, perhaps we should
>>> carry that through into pcbnew legacy and eeschema. Wayne?
>>
>> I'm fine with this. That means that no additional tool required to make
>> this work. Just use the standard select tool plus the ctrl key.
>
> Perhaps if I get the time I will make pcbnew legacy work this way and
> remove the tool. I'm wondering if we should split this commit: accept
> Nox's patch working the way it does, which matches pcbnew legacy (as
> eeschema usually does), then edit both pcbnew legacy and eeschema to
> work like pcbnew GAL in a separate commit.

I'm fine with this as long as it is going to get fixed. I want to avoid
another drive by patch that never get finished because it satisfies the
needs of the person who submitted the patch but has no intention of
seeing it through the end.

>
> Also slightly offtopic, I wonder if something should be done to make
> things like this more obvious. I really like the convenience of
> ctrl+click in GAL, but had absolutely no idea it was there until one of
> the GAL devs told me. A lot of software that makes heavy use of
> modifiers displays a summary of active cursor modkeys and their meanings
> in the status bar...

I'm guessing you could add a help string to the status bar or maybe a
more descriptive tooltip.

>
>>
>>>
>>> Nox: I haven't had a chance to test the updated patch yet, but on the
>>> patch getting bulky - personally, I don't feel it's excessively large.
>>> Actually I feel you've done a good job of keeping things minimal - I
>>> only see two "large" blocks of code added, and they're only a couple
>>> dozen lines each. Plus the necessary glue to tie those into the UI. I
>>> personally would not worry about the patch size at this point.
>>>
>>
>> --
>> You received this bug notification because you are a member of KiCad Bug
>> Squad, which is subscribed to KiCad.
>> https://bugs.launchpad.net/bugs/594073
>>
>> Title:
>> Highlight Nets
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/kicad/+bug/594073/+subscriptions
>